Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clang warnings #11681

Closed
1 task done
quantumsteve opened this issue Dec 19, 2014 · 2 comments · Fixed by #15463
Closed
1 task done

fix clang warnings #11681

quantumsteve opened this issue Dec 19, 2014 · 2 comments · Fixed by #15463
Assignees
@quantumsteve
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.7

Comments

@quantumsteve
Copy link
Contributor

This issue was originally TRAC 10839

This ticket is blocked by :

Currently the warning options in GNUSetup.cmake are not enabled when building with clang on OSX. We want to systematically enable these additional warning options and fix any issues they uncover.
@quantumsteve
Copy link
Contributor Author

@quantumsteve (2015-03-10T22:05:34):
warnings when building Mantid with -Wcast-align

@quantumsteve (2015-03-10T22:15:09):
-Wcast-align generates many warnings in "ugly" portions of our codebase. Unfortunately, we are not aware of a safer alternative that would both be correct and suppress these warnings.

@quantumsteve quantumsteve added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@quantumsteve quantumsteve self-assigned this Jun 3, 2015
@quantumsteve quantumsteve added this to the Release 3.5 milestone Jun 3, 2015
@quantumsteve
Copy link
Contributor Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/10839/Wcast-align_warnings.txt
(uploaded by @quantumsteve on 2015-03-10T22:05:34)

DanNixon added a commit that referenced this issue Jun 5, 2015
@DanNixon
Suppress false errors on IDR
fa50ab9 
Refs #11681
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@quantumsteve quantumsteve mentioned this issue Feb 25, 2016
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quantumsteve quantumsteve

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.7
Development

Successfully merging a pull request may close this issue.

Combine OS X and Linux compiler flags. mantidproject/mantid
2 participants
@NickDraper @quantumsteve