Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old LoadXXX (LoadEventPreNexus, LoadAscii) need "previous versions" documentation and/or deprecation #11707

Closed
mantid-builder opened this issue Jan 8, 2015 · 5 comments · Fixed by #13933
Assignees
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 10865

Original Reporter: @FedeMPouzols

This ticket is blocks : TRAC10619

Checking old versions of LoadXXX (in http://trac.mantidproject.org/mantid/ticket/8175) this is what I found. For the following algorithm there is an older version that is still in use and documented:

Perfect, nothing to do there. But for the following two algorithms there is no "previous versions" documentation (or about why the older versions are still there):

For these two, it should be documented why the older versions are still provided (or they should be deprecated if there's no reason any longer). At first glance, in both algorithms, it looks like the newer versions are just expanded versions of the old ones.

Try to find those who might know the history of versions and clarify what's the current status of these algorithms/versions.


Keywords: Maintenance

@mantid-builder
Copy link
Collaborator Author

@NickDraper (2015-04-27T08:10:35):
Moved to R3.5 at the R3.4 code freeze

@mantid-builder mantid-builder added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper
Copy link
Contributor

see #9020 as well

@NickDraper
Copy link
Contributor

LoadMuonNexus is in current use
LoadAscii Version 1 used a rubbish format for 2D data, and can be discarded / removed
As to wether LoadPreEventNexus v1 can be removed we need to get an answer from @peterfpeterson or @stuartcampbell

@peterfpeterson
Copy link
Member

I don't think LoadPreEventNexus v1 is used. v2 works everywhere that I have needed it to.

@stuartcampbell: do you use any of them?

@NickDraper NickDraper self-assigned this Oct 12, 2015
@NickDraper
Copy link
Contributor

Plan:
LoadMuonNexus: Add Previous Versions documentation -> actually this already exists in the V2 doc file
LoadAscii: Deprecate V1
LoadPreEventNexus: Deprecate V1

NickDraper added a commit that referenced this issue Oct 12, 2015
NickDraper added a commit that referenced this issue Oct 12, 2015
Also move examples from LoadMuonNexusV1 to V2

re #11707
NickDraper added a commit that referenced this issue Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants