Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mover run properties to descriptor and move common run functionality to them #11720

Closed
1 task done
abuts opened this issue Jan 12, 2015 · 1 comment
Closed
1 task done

Mover run properties to descriptor and move common run functionality to them #11720

abuts opened this issue Jan 12, 2015 · 1 comment
Assignees
@abuts
Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Milestone
Release 3.4

Comments

@abuts
Copy link
Member

abuts commented Jan 12, 2015

This ticket is blocked by :

This ticket is blocks : TRAC10684, TRAC10958

Currently run properties in reducer are simple python properties
(e.g. sample_run, wb_run monovan_run) with all necessary functionality spread among multiple files (common_functions, DirectEnergyConversion and PropertyManager) which leads to code duplication and ineffective testing.

The purpose of this ticket is to collect all functionality (load, getMonitorWorkspace, sum) together within a RunFileDescriptor and write unit/system tests to ensure this functionality.

Also it would be nice to decrease DirectEnergy conversion size.
@abuts abuts added the Direct Inelastic Issues and pull requests related to direct inelastic label Jun 3, 2015
@abuts abuts self-assigned this Jun 3, 2015
@abuts abuts added this to the Release 3.4 milestone Jun 3, 2015
@abuts
Copy link
Member Author

abuts commented Jun 3, 2015

This issue was originally trac ticket 10881

@abuts abuts closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
1 participant
@abuts