New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnginXFitPeaks expected Peak analysis problem #11746
Comments
@NickDraper (2015-04-27T08:10:34): Federico M Pouzols (2015-05-06T15:52:18): Federico M Pouzols (2015-06-02T21:11:32):
|
It looks like this is the behavior that we want: if errors such as 'some peaks were not found by FindPeaks' happen, the calibration algorithms should continue as far as possible. The output files generated will have a suffix like '_with_errrors` appended, to give a hint. When used from the GUI, a pop-up should warn the user, before the "peaks diagnostics" visualization, but it should still be possible to go on and then accept the diagnostics step and save the files. |
This issue was originally TRAC 10907
This ticket is blocks : TRAC8368
When entering a list of expectedPeaks into FitPeaks, if one expected peak is not there, the algorithm will stop and not produce any results. If just one peak is out of range of the data then this should be stated but otherwise ignored. If all expectedPeaks are not there then the algorithm should fail gracefully.
This affects EnginXCalibrate and CalibrateFull which both utilise FitPeaks.
The text was updated successfully, but these errors were encountered: