Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnginXFitPeaks expected Peak analysis problem #11746

Closed
lottiegreenwood opened this issue Jan 16, 2015 · 2 comments · Fixed by #12970
Closed

EnginXFitPeaks expected Peak analysis problem #11746

lottiegreenwood opened this issue Jan 16, 2015 · 2 comments · Fixed by #12970
Assignees
Labels
Diffraction Issues and pull requests related to diffraction
Milestone

Comments

@lottiegreenwood
Copy link

This issue was originally TRAC 10907

This ticket is blocks : TRAC8368

When entering a list of expectedPeaks into FitPeaks, if one expected peak is not there, the algorithm will stop and not produce any results. If just one peak is out of range of the data then this should be stated but otherwise ignored. If all expectedPeaks are not there then the algorithm should fail gracefully.

This affects EnginXCalibrate and CalibrateFull which both utilise FitPeaks.

@lottiegreenwood
Copy link
Author

@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze


Federico M Pouzols (2015-05-06T15:52:18):
(In http://trac.mantidproject.org/mantid/ticket/8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.


Federico M Pouzols (2015-06-02T21:11:32):
Note that in addition to

  • sometimes FindPeaks will not find the expected peaks
    The following can happen:
  • FindPeaks finds them, but it produces 0 width and/or height
    This is currently skipped with an if... continue when processing the workspace spectra.

@lottiegreenwood lottiegreenwood added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@lottiegreenwood lottiegreenwood added this to the Release 3.5 milestone Jun 3, 2015
@FedeMPouzols
Copy link
Contributor

It looks like this is the behavior that we want: if errors such as 'some peaks were not found by FindPeaks' happen, the calibration algorithms should continue as far as possible. The output files generated will have a suffix like '_with_errrors` appended, to give a hint.

When used from the GUI, a pop-up should warn the user, before the "peaks diagnostics" visualization, but it should still be possible to go on and then accept the diagnostics step and save the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants