Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EnginX expectedPeaks loading for all EnginX algorithms #11749

Closed
1 task done
lottiegreenwood opened this issue Jan 16, 2015 · 1 comment
Closed
1 task done
Assignees
Labels
Diffraction Issues and pull requests related to diffraction
Milestone

Comments

@lottiegreenwood
Copy link

This issue was originally TRAC 10910

This ticket is blocked by :

This ticket is blocks : TRAC8368

Use .csv file browser/defaults made in http://trac.mantidproject.org/mantid/ticket/10605 and move it into EnginX Utils, enabling it to be used by the other EnginX algorithms.

@lottiegreenwood
Copy link
Author

@lottiegreenwood (2015-01-29T13:58:04):
Refs http://trac.mantidproject.org/mantid/ticket/10910 changed loading to csv

c3770dc


@lottiegreenwood (2015-01-29T13:58:04):
Refs http://trac.mantidproject.org/mantid/ticket/10910 csv loading added in calibrateFull

95b752c


@lottiegreenwood (2015-01-29T13:58:04):
Refs http://trac.mantidproject.org/mantid/ticket/10910 csv loading added in calibrate

ead10cb


@NickDraper (2015-04-27T08:10:35):
Moved to R3.5 at the R3.4 code freeze


Federico M Pouzols (2015-05-06T15:52:18):
(In http://trac.mantidproject.org/mantid/ticket/8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.


Federico M Pouzols (2015-05-29T09:12:52):
To do:

  • move _readInExpectedPeaks() and _getDefaultPeaks() from EnginXFitPeaks.py to EnginXUtils.py
  • add a property like self.declareProperty(FileProperty(name="ExpectedPeaksFromFile"... in EnginXCalibrate, and EnginXCalibrateFull.

Also, if http://trac.mantidproject.org/mantid/ticket/10909 and http://trac.mantidproject.org/mantid/ticket/10967 (the two tickets that add an optional output table with difz, zero) are merged, this ticket could also include:

  • refactor/merge the "_produceOutputs() + _generateOutputParFitTable() stuff" from EnginXFitPeaks and EnginXCalibrate (largely duplicate code) and move it into EnginXUtils.py

@lottiegreenwood lottiegreenwood added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@lottiegreenwood lottiegreenwood added this to the Release 3.5 milestone Jun 3, 2015
eXeC64 pushed a commit that referenced this issue Jun 4, 2015
eXeC64 pushed a commit that referenced this issue Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

No branches or pull requests

2 participants