Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickNXS: Resolve hardcoded instrument values #11763

Closed
eXeC64 opened this issue Jan 20, 2015 · 3 comments
Closed

QuickNXS: Resolve hardcoded instrument values #11763

eXeC64 opened this issue Jan 20, 2015 · 3 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@eXeC64
Copy link
Contributor

eXeC64 commented Jan 20, 2015

This issue was originally TRAC 10924

aglavic/quicknxs#5 introduces many comments annotating areas of the QuickNXS code that are troublesome for ISIS. These hardcoded values and strings need to be resolved before ISIS can begin to use QuickNXS.

There are three comments introduced:

  • TODO MAGIC NUMBER - Highlights a hardcoded numbers
  • TODO HARDCODED STRING - Highlights hardcoded strings
  • TODO HARDCODED INSTRUMENT - Highlights hardcoded dependencies on an instrument

They should be easily findable using git grep. The goal of this ticket is to review each highlighted area and resolve it, until all of the TODO comments have been removed.

@eXeC64
Copy link
Contributor Author

eXeC64 commented May 12, 2015

@NickDraper (2015-05-12T14:03:07):
Moved to R3.5 at the end of R3.4

@eXeC64 eXeC64 added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@eXeC64 eXeC64 added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestone: Release 3.6 Jan 22, 2016
@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants