A few SINQ classes don't have unit tests: SINQHMListener, SINQTranspose3D, PoldiPeakDetection2, ... PoldiLoadSpectra

[mantid-builder]

This issue was originally TRAC 10941

Original Reporter: @FedeMPouzols

While checking how http://trac.mantidproject.org/mantid/ticket/8492 could be tested, I realized that there is no test for SINQHMListener. Other classes in Framework/SINQ are also missing a unit test:

• PoldiRemoveDeadWires
• PoldiPeakDetection2
• PoldiLoadLog
• PoldiLoadChopperSlits
• PoldiAutoCorrelation5
• PoldiLoadIPP
• PoldiLoadSpectra
• SINQTranspose3D
  (all are algorithms).

Probably this is not terribly critical for these classes taken one at a time, but the fact that a good bunch of them don't have unit tests looks a bit reckless.

RST documentation is also missing for:

• SINQTranspose3D

• PoldiPeakDetection2

• PoldiAutoCorrelation5

  Keywords: Maintenance

[mantid-builder]

@FedeMPouzols (2015-01-22T10:05:19):
The title was very long.

[NickDraper]

is this still valid?

[MichaelWedel]

The Poldi algorithms have been replaced in the meantime or properly documented and tested so for these the issue should be closed. For SINQTranspose3D and SINQHMListener I don't know, this is the domain of @mkoennecke, he knows what the algorithms are doing.

I think it would be best to close this issue and create a new one for the remaining two algorithms which can be forwarded to Mark.

[mkoennecke]

Hi,

Am 15.02.2016 um 13:26 schrieb Michael Wedel <notifications@github.commailto:notifications@github.com>:

The Poldi algorithms have been replaced in the meantime or properly documented and tested so for these the issue should be closed. For SINQTranspose3D and SINQHMListener I don't know, this is the domain of @mkoenneckehttps://github.com/mkoennecke, he knows what the algorithms are doing.

I think it would be best to close this issue and create a new one for the remaining two algorithms which can be forwarded to Mark.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11780#issuecomment-184186163.

Both of these classes are of local use at SINQ only and thus do not need formalized tests. If there would be a Mantid plugin
system they would live in a SINQ-plugin. SINQHMListener is a listener for our SinqHM histogram memory software and an automated
test for that one would need an extra C-executable to be added to Mantid. SINQTranspose3D fixes a data order issue with one of our
instruments.

Regards,

Mark Könnecke

[MichaelWedel]

@mkoennecke, thanks for clarifying!

That means I will close the issue now and not open a new one.