Clarify issues with static methods in LoadEventNexus being used by other algorithms

[mantid-builder]

This issue was originally TRAC 10975

Original Reporter: @FedeMPouzols

This ticket is blocks : TRAC10619

As explained in http://trac.mantidproject.org/mantid/ticket/8172#comment:18, the LoadEventNexus algorithm class has several static methods that are used from other algorithms:

• LoadEventNexus::LoadEntryMetadata: used by LoadTOFRawNexus, LoadNexusMonitors
• LoadEventNexus::runLoadIDFFromNexus: used by LoadISISNexus2
• LoadEventNexus::runLoadInstrument: used by LoadTOFRawNexus, LoadPreNexus
• LoadEventNexus::runLoadNexusLogs: used by LoadTOFRawNexus

To re-use the already open NeXus file instead of re-opening it several times, these algorithms would need to be updated at once, so this was left out of ticket http://trac.mantidproject.org/mantid/ticket/8172.

In principle it should be possible to pass the (static) methods listed above a reference or pointer to the NeXus::File objects instead of/in addition to the file name.

Also, this use of static methods looks a bit suspicious and calling for maintenance trouble. Clarify and/or fix this issue.

---

Keywords: Maintenance, CORE

[mantid-builder]

@FedeMPouzols (2015-02-06T13:01:01):
Added CORE keyword as suggested by @Anders-Markvardsen .

---

@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze

[FedeMPouzols]

There may be a chance to revisit this in the "loaders design document"?
@KarlPalmen @raquelalvarezbanos @Anders-Markvardsen

[KarlPalmen]

This design document is at https://github.com/mantidproject/documents/blob/loader-refectorisation/Design/loaderfact.md

[NickDraper]

Too old, no progress closing.