Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuggestTIBCNCS error #11818

Closed
AndreiSavici opened this issue Jan 27, 2015 · 1 comment
Closed

SuggestTIBCNCS error #11818

AndreiSavici opened this issue Jan 27, 2015 · 1 comment
Assignees
@AndreiSavici
Labels
Direct Inelastic Issues and pull requests related to direct inelastic High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.4

Comments

@AndreiSavici
Copy link
Member

when using Ei=6, the algorithm does not find a correct TIB range. This is an error about dealing with the location of prompt pulse if it is next to the T_inf

Keywords: patch candidate
@AndreiSavici
Copy link
Member Author

This issue was originally trac ticket 10979

@AndreiSavici AndreiSavici added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Direct Inelastic Issues and pull requests related to direct inelastic labels Jun 3, 2015
@AndreiSavici AndreiSavici self-assigned this Jun 3, 2015
@AndreiSavici AndreiSavici added this to the Release 3.4 milestone Jun 3, 2015
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
First implementation of changes
da16824 
 1. IDS mangling used for checksum is now inst name + sha1 of xml
 1.1. sha1 is computed after converitng to linux line endings and trim
 1. VTP file names changes to be same filename as IDS mangling
 1. VTP save directory moved to appdata/mantidproject/instrument/geometryCache
 1. VTP file saving simplified as files based on a checksum cannot be out of date
 1. unit tests updated to account for this
 1. unused methods removed from IDFObject
 1. InstrumentDefinitionParser changed to initialise during constructor
 1. XML parsing changed to lazy load rather than during initialisation.

Still to do:
 1. cache SHA1 checksum if needed
 1. Change the filename reported for nexus files
 1. Manually test
 1. Stop saving the filename to nexus files
 1. update documentation

re #11818
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
Further steps as defined below
0e064a7 
 1. Change the filename reported for nexus files if xml contained within
 1. Stop saving the filename to nexus processed files
 1. removed some unused includes

Still to do:
 1. cache SHA1 checksum if needed
 1. Manually test
 1. update documentation
 1. investigate this error:

ctest -C Debug -J 4 -R LoadEventNexusTest -V

 548: LoadParameterFile-[Error] Bad path syntax: C:\Mantid\Code\Mantid\instrument
\C:\Users\rrc79113\AppData\Roaming\mantidproject\mantid\instrument\HYSPECA_Param
eters.xml. Unable to parse File: in C:/Mantid/Code/Mantid/instrument//C:\Users\r
rc79113\AppData\Roaming\mantidproject\mantid\instrument\HYSPECA_Parameters.xml
548: LoadIDFFromNexus-[Notice] Instrument parameter file: C:\Users\rrc79113\AppD
ata\Roaming\mantidproject\mantid\instrument\HYSPECA_Parameters.xml not found or
un-parsable. Instrument parameter file: C:/Mantid/Code/Mantid/instrument/HYSPECA
_Parameters.xml has been loaded

re #11818
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
fixed the following unit test failures
5ac567b 
        712 - AlgorithmsTest_CreateDummyCalFileTest (Failed)
        1181 - MDAlgorithmsTest_LoadMDTest (Timeout)
        1195 - MDAlgorithmsTest_MergeMDFilesTest (Failed)

re #11818
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
Error 4: from above the instrument parameter loading is fixed
455e782 
re #11818
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
re #11818 for doxygen warning
b34f136
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
re #11818 update documentation
c4aded7
NickDraper added a commit that referenced this issue Jun 15, 2015
@NickDraper
re #11818 update documentation
c817b1b
abuts added a commit that referenced this issue Jun 21, 2015
@abuts
Re #11818 Minor change increasing reliability of pyslice
33cf122 
if user pushes a button in incorrect order.
abuts added a commit that referenced this issue Aug 10, 2015
@abuts @peterfpeterson
Re #11818 Minor change increasing reliability of pyslice
29d6f21 
if user pushes a button in incorrect order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiSavici AndreiSavici

Labels
Direct Inelastic Issues and pull requests related to direct inelastic High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
1 participant
@AndreiSavici