Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load ISIS Nexus does not load correct monitor information if monitors are loaded separately form workspace #11819

Closed
abuts opened this issue Jan 27, 2015 · 1 comment
Closed

Load ISIS Nexus does not load correct monitor information if monitors are loaded separately form workspace #11819

abuts opened this issue Jan 27, 2015 · 1 comment
Assignees
@abuts
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.4

Comments

@abuts
Copy link
Member

abuts commented Jan 27, 2015

Try to load MAPS workspace (tried on the run MAP21384.nxs) which can be found on data service or ftp at: ftp://ftp.nd.rl.ac.uk/scratch/abuts/Ticket_10980/

and select monitors-include. Look at detector table -- it has correct monitors with correct monitors positions.

Try to load monitors separately -- Monitors workspace do not have spectra ID, detectors ID and spectra are not marked as monitors.

Fixing this ticket should also involve fixing system test:

ISISDirectReductionComponents, (row 189, reference to this ticket)
and verifying it passes. The reason it fails is this bug.
@abuts
Copy link
Member Author

abuts commented Jun 3, 2015

This issue was originally trac ticket 10980

@abuts abuts added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@abuts abuts self-assigned this Jun 3, 2015
@abuts abuts added this to the Release 3.4 milestone Jun 3, 2015
@abuts abuts closed this as completed Jun 3, 2015
DanNixon added a commit that referenced this issue Jun 4, 2015
@DanNixon
Added algorithm and documentation page
4c2951c 
Refs #11819
DanNixon added a commit that referenced this issue Jun 4, 2015
@DanNixon
Add unit tests Refs #11819
c3c1fd6
DanNixon added a commit that referenced this issue Jun 4, 2015
@DanNixon
Remove statement used for debugging
83f58c7 
Refs #11819
DanNixon added a commit that referenced this issue Jun 4, 2015
@DanNixon
Use correct test assertion
992e55c 
Refs #11819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
1 participant
@abuts