Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EQSANS dark current subtraction #11863

Closed
mdoucet opened this issue Feb 5, 2015 · 2 comments
Closed

Update EQSANS dark current subtraction #11863

mdoucet opened this issue Feb 5, 2015 · 2 comments
Assignees
@mdoucet
Labels
SANS Issues and pull requests related to SANS
Milestone
Release 3.5

Comments

@mdoucet
Copy link
Member

mdoucet commented Feb 5, 2015

This issue was originally TRAC 11024

Improve the EQSANS dark current subtraction
Dark counts should be loaded with LoadEventNexus, scaled according to the TOF cuts applied to the sample data, and scale to acquisition time.
@mdoucet
Copy link
Member Author

mdoucet commented Apr 27, 2015

@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze

@mdoucet mdoucet added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@mdoucet mdoucet self-assigned this Jun 3, 2015
@mdoucet mdoucet added this to the Release 3.5 milestone Jun 3, 2015
mdoucet added a commit that referenced this issue Aug 3, 2015
@mdoucet
Re #11863 Reimplement dark current subtraction
8e177d8
mdoucet added a commit that referenced this issue Aug 3, 2015
@mdoucet
Re #11863 add documentation
49db3ef
mdoucet added a commit that referenced this issue Aug 3, 2015
@mdoucet
Re #11863 Give algo proper name
4be35d7
mdoucet added a commit that referenced this issue Aug 7, 2015
@mdoucet
Re #11863 Use duration property
0eaf69b
mdoucet added a commit that referenced this issue Aug 7, 2015
@mdoucet
Re #11863 Fix system test
e7532de
mdoucet added a commit that referenced this issue Aug 7, 2015
@mdoucet
Re #11863 update ref data
91cfa09
mdoucet added a commit that referenced this issue Aug 10, 2015
@mdoucet
Re #11863 update ref data for second failing test
ae1cd18
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@mdoucet mdoucet modified the milestones: Release 3.5, Release 3.6 Oct 2, 2015
@mdoucet
Copy link
Member Author

mdoucet commented Oct 2, 2015

This has been fixed in PR #13285

@mdoucet mdoucet closed this as completed Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdoucet mdoucet

Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.5
Development

No branches or pull requests
2 participants
@NickDraper @mdoucet