Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Muon CalibrateDetectors algorithm #11868

Closed
raquelalvarezbanos opened this issue Feb 6, 2015 · 2 comments
Closed

Create Muon CalibrateDetectors algorithm #11868

raquelalvarezbanos opened this issue Feb 6, 2015 · 2 comments
Assignees
Labels
Muon Issues and pull requests related to muons
Milestone

Comments

@raquelalvarezbanos
Copy link
Contributor

This issue was originally TRAC 11029

This ticket is blocks : TRAC11030

Add CalibrateDetectors algorithm to compute the phase list that will be used as input to PhaseQuad algorithm, according to code provided by muon scientists.

@raquelalvarezbanos
Copy link
Contributor Author

@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze

@raquelalvarezbanos raquelalvarezbanos added the Muon Issues and pull requests related to muons label Jun 3, 2015
@raquelalvarezbanos raquelalvarezbanos self-assigned this Jun 3, 2015
@raquelalvarezbanos raquelalvarezbanos added this to the Release 3.5 milestone Jun 3, 2015
OwenArnold added a commit that referenced this issue Jun 4, 2015
OwenArnold added a commit that referenced this issue Jun 4, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@raquelalvarezbanos
Copy link
Contributor Author

The algorithm should be called 'CalMuonDetectorPhases'.

It should take a reference input workspace and:

  1. Remove the exponential decay
  2. Fit each spectrum to f(x) = A * sin ( omega * t + phi ). Where omega is shared across spectra.
  3. The output should be a table workspace with three columns (one per detector/spectrum): (detectorID, A, phi)

Additional considerations:

  • Check input workspace's units, they should be microseconds
  • The fitting parameter A must be positive, if it is not, add a phase of pi
  • The algorithm should have two optional properties to select the start and end times. If these are not provided, the end time should be set to the last X value available, and the start time should be set to firstGoodData
  • Another optional property: starting hint for the frequency. If the user does not supply one, start with sample_magn_field * 0.01355 MHz/G, where sample_magn_field can be read from the header/logs.
  • Optional output workspace: workspace containing fitting results

This new algorithm can be tested doing the following:

  • Take a transverse field muon dataset, ws
  • Run CalMuonDetectorPhases on ws to get the phase table tab
  • Run PhaseQuad on ws using tab
  • The real part of the output workspace should be cos( omega * t ) and the imaginary part sin( omega * t )

raquelalvarezbanos added a commit that referenced this issue Oct 2, 2015
raquelalvarezbanos added a commit that referenced this issue Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Muon Issues and pull requests related to muons
Projects
None yet
Development

No branches or pull requests

2 participants