Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clang warnings and errors #11949

Closed
quantumsteve opened this issue Feb 17, 2015 · 1 comment
Closed

fix clang warnings and errors #11949

quantumsteve opened this issue Feb 17, 2015 · 1 comment
Assignees
@quantumsteve
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.4

Comments

@quantumsteve
Copy link
Contributor

Both a new compiler warning and error was recently introduced on master.

15:44:20 /Users/builder/jenkins-linode/workspace/master_clean-clang/label/osx-10.9-build/Code/Mantid/Framework/Kernel/src/InternetHelper.cpp:137:35: error: invalid operands to binary expression ('std::ostream' (aka 'basic_ostream<char>') and 'std::ostringstream' (aka 'basic_ostringstream<char>'))
15:44:20 session.sendRequest(*m_request) << m_body;

02:59:12 /Users/builder/jenkins-linode/workspace/master_clean-clang/label/osx-10.9-build/Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSymmetrise.cpp:278:14: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
02:59:12 if((prop == m_properties["PreviewSpec"]))
@quantumsteve
Copy link
Contributor Author

This issue was originally trac ticket 11110

@quantumsteve quantumsteve added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@quantumsteve quantumsteve self-assigned this Jun 3, 2015
@quantumsteve quantumsteve added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quantumsteve quantumsteve

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
1 participant
@quantumsteve