Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why OSIRIS I(Q, t) fit test fails on OSX #11989

Closed
DanNixon opened this issue Feb 20, 2015 · 3 comments · Fixed by #16915
Closed

Investigate why OSIRIS I(Q, t) fit test fails on OSX #11989

DanNixon opened this issue Feb 20, 2015 · 3 comments · Fixed by #16915
Assignees
@ElliotAOram
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic

Comments

@DanNixon
Copy link
Member

This issue was originally TRAC 11150

This test fails as the Tau spectrum has an artefact in it that is far enough out of the comparison tolerance to fail the test.
@DanNixon DanNixon added the Indirect/Inelastic Issues and pull requests related to indirect or inelastic label Jun 3, 2015
@DanNixon DanNixon self-assigned this Jun 3, 2015
@DanNixon DanNixon assigned ElliotAOram and unassigned DanNixon Jul 30, 2015
@DanNixon DanNixon changed the title Investigate why OSIRIS fury fit test fails on OSX Investigate why OSIRIS I(Q, t) fit test fails on OSX Jul 31, 2015
@ElliotAOram
Copy link
Contributor

This no longer appears to be the case as no OSX tests are failing

@DanNixon
Copy link
Member Author

It doesn't fail because it's skipped on OSX: https://github.com/mantidproject/mantid/blob/master/Testing/SystemTests/tests/analysis/ISISIndirectInelastic.py#L1017

@ElliotAOram
Copy link
Contributor

Ah okay, sorry didn't realise this. Thanks

@ElliotAOram ElliotAOram mentioned this issue Jul 6, 2016
Merged
9 tasks
ElliotAOram pushed a commit that referenced this issue Jul 19, 2016
Remove test skipping for Darwin
4bd2e64 
Refs #11989
@ElliotAOram ElliotAOram mentioned this issue Jul 19, 2016
Merged
9 tasks
ElliotAOram pushed a commit that referenced this issue Jul 20, 2016
Remove unused import
8bc3a0c 
Refs #11989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElliotAOram ElliotAOram

Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Milestone
No milestone
2 participants
@DanNixon @ElliotAOram