Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken systemtest caused by FunctionParameterDecorator #12058

Closed
MichaelWedel opened this issue Mar 4, 2015 · 1 comment
Closed

Fix broken systemtest caused by FunctionParameterDecorator #12058

MichaelWedel opened this issue Mar 4, 2015 · 1 comment
Assignees
@MichaelWedel
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.4

Comments

@MichaelWedel
Copy link
Contributor

The default implementation of FunctionParameterDecorator::nParams() was a bit too strict in throwing an exception if no function is actually decorated, causing the CodeConventions system test to fail with this message:

for i in xrange(function.numParams()):
RuntimeError: No wrapped function set, aborting.

Returning 0 in case of no function being decorated will solve this issue.

Keywords: Fitting
@MichaelWedel
Copy link
Contributor Author

This issue was originally trac ticket 11219

@MichaelWedel MichaelWedel added Framework Issues and pull requests related to components in the Framework Fitting labels Jun 3, 2015
@MichaelWedel MichaelWedel self-assigned this Jun 3, 2015
@MichaelWedel MichaelWedel added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelWedel MichaelWedel

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
1 participant
@MichaelWedel