Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to MD is slow for some diffraction cases #12115

Closed
martyngigg opened this issue Mar 5, 2015 · 6 comments
Closed

Convert to MD is slow for some diffraction cases #12115

martyngigg opened this issue Mar 5, 2015 · 6 comments
Assignees
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@martyngigg
Copy link
Member

This issue was originally TRAC 11276

Leighton Coates has an example where ConvertToMD is extremely slow. This needs profiling to understand why.


Keywords: SSC 2015 sns SX

@martyngigg
Copy link
Member Author

@NickDraper (2015-03-10T15:49:01):
Batch modify all SSC tickets to critical priority (this will also show up as an update for all those already as critical)


@NickDraper (2015-03-11T10:15:57):
Assigned to Martyn to do the profiling and find the bottleneck (unless transfering the data is too hard). Implementation may be elsewhere depending on results

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction SSC Single Crystal Issues and pull requests related to single crystal labels Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.5 milestone Jun 3, 2015
@martyngigg
Copy link
Member Author

I have emailed Leighton to ask for an example

@NickDraper NickDraper added Diffraction Issues and pull requests related to diffraction and removed Diffraction Issues and pull requests related to diffraction labels Jun 30, 2015
@martyngigg martyngigg modified the milestones: Release 3.6, Release 3.5 Sep 7, 2015
@martyngigg martyngigg removed the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Sep 14, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@NickDraper NickDraper modified the milestones: Release 3.8, Release 3.9 Oct 3, 2016
@NickDraper NickDraper modified the milestones: Release 3.9, Temporary Holding Oct 14, 2016
@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
@OwenArnold
Copy link
Contributor

@martyngigg would be good to get the test case for this. Might be interesting to see if what @igudich has been doing fixes the performance.

@martyngigg
Copy link
Member Author

@OwenArnold We had been waiting on an instrument scientist in the US to give us a test case. @peterfpeterson Do you know if there are still issues here? We captured this quite some time ago...

@stale
Copy link

stale bot commented Feb 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 23, 2021
@martyngigg
Copy link
Member Author

Closing due to lack of user response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants