Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User experience improvements for reactor source experiments #12121

Closed
AndreiSavici opened this issue Mar 5, 2015 · 1 comment
Closed

User experience improvements for reactor source experiments #12121

AndreiSavici opened this issue Mar 5, 2015 · 1 comment
Assignees
Labels
Diffraction Issues and pull requests related to diffraction
Milestone

Comments

@AndreiSavici
Copy link
Member

As part of testing ticket http://trac.mantidproject.org/mantid/ticket/10929 I have found a few things left to improve

  1. LoadSpiceAscii should not require dat time format
  2. ConvertSpiceDataToRealSpace creates an MD workspace with Y min and max limits both 0
  3. ConvertCWPDMDToSpectra is a weird name. It should at least be explained in the documentation
  4. Binning parameters must contain 3 numbers. People might be used to Rebin, that can also use one value. Minimum and maximum can be calculated
  5. There is a weird warning message "Unable to set unit to an Unit::Empty object." The reason is that the "Degrees" unit is not registered.
    Changes:
    a) Code/Mantid/Framework/Kernel/inc/MantidKernel/Unit.h, line 616, replace
{ return ""; }

with

;

b) Code/Mantid/Framework/Kernel/src/Unit.cpp add line 1121

DECLARE_UNIT(Degrees)

c) fix code in Code/Mantid/Framework/MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp about Twotheta to

pdws->getAxis(0)->setUnit("Degrees");
@AndreiSavici
Copy link
Member Author

This issue was originally trac ticket 11282

@AndreiSavici AndreiSavici added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@AndreiSavici AndreiSavici added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

No branches or pull requests

2 participants