Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Splitting Follow on Fixes #12159

Closed
1 task done
OwenArnold opened this issue Mar 11, 2015 · 3 comments
Closed
1 task done

Initial Splitting Follow on Fixes #12159

OwenArnold opened this issue Mar 11, 2015 · 3 comments
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@OwenArnold
Copy link
Contributor

This issue was originally TRAC 11320

This ticket is blocked by :

  1. ConvertToMD::performInitialSplitting should not have a hard-coded number of boxes. Although 50 is likely to remain as the default, It worries me that we cannot change this without recompiling and distributing mantid. Can you change this to be a user property which defaults to 50?

  2. The initial splitting is Off by default, Nick's opinion is now that it should be ON by default. In the code use true/false rather than 0/1 to set default values. It's just a coincidence that 1 == true and 0 == false in c++, makes for more readable code if you don't mix boolean and integer types.

  3. Unit tests should be made to run fast. If you cannot get the time down < 1 second, for this test method, then write it as a system test.

@OwenArnold
Copy link
Contributor Author

@NickDraper (2015-04-27T08:10:35):
Moved to R3.5 at the R3.4 code freeze

@OwenArnold OwenArnold added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.8, Release 3.9 Oct 3, 2016
@NickDraper NickDraper modified the milestones: Release 3.9, Temporary Holding Oct 14, 2016
@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
@AntonPiccardoSelg
Copy link
Contributor

Should be easy to do and something that @Mantid-Matthew can use to get into VATES

@Matthew-Andrew
Copy link
Contributor

closing as stale

@Matthew-Andrew Matthew-Andrew removed their assignment Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

4 participants