Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory, initialization and other issues (coverity) in Framework (especially Load...) #12167

Closed
mantid-builder opened this issue Mar 12, 2015 · 1 comment
Closed

Fix memory, initialization and other issues (coverity) in Framework (especially Load...) #12167

mantid-builder opened this issue Mar 12, 2015 · 1 comment
Assignees
@FedeMPouzols
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.4

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: @FedeMPouzols

This ticket is blocks : TRAC10619

This is a bunch of coverity issues (~30), with a bit of focus on Framework, and inside framework, on the Load* classes and related helpers.

Unitialized member vars (scalars and pointers):

  • 1075408: LoadEventPreNexus2 constructor
  • 1075417: LoadPreNexusMonitors constructor
  • 1075403: LoadMask constructor
  • 1075405: LoadLLB
  • 1075411: LoadDetectorsGroupingFile.cpp: LoadDetectorsGroupingFile constructor
  • 1075412: LoadDetectorsGroupingFile.cpp: LoadGroupXMLFile constructor
  • 1075399: LoadRawBin0 constructor
  • 1075398: LoadRawHelper
  • 1075397: LoadRawSpectrum0
  • 1127169: LoadSINQFocus
  • 1075395: LoadTOFRawNexus
  • 1237306: LoadVulcanCalFile
  • 1075349: LoadSQW.h / LoadSQWHelper
  • 1075341: LoadSQW
  • 1075404: LoadLogsForSNSPulsedMagnet
  • 1075401: LoadRaw / item_struct constructor

A few remaining leaks, supposedly high impact:

  • 1271720, 21: leaks in AffineMatrixParameter (false positives I'd say), but the destructor can be improved so that we don't get this false positive and everything is more clear.
  • 1271722: similar issue as above, in CoordTransformAffine

Unchecked dynamic_casts

  • 1223399: LoadILLReflectometry
  • 1223400: LoadILLReflectometry
  • 1076257: ​HFIRLoad
  • 1076262, 63, 64: EQSANSLoad

Integer handling:

  • 1076097: LoadRawBin0 (int32/64 cast)
  • 1076096: ​LoadRawHelper
  • 1076095: LoadRawSpectrum0

Control flow:

  • 1075695: LoadCanSAS1D, Missing break in switch

Unchecked return values:

  • 1076114: LoadRawHelper
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 11328

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FedeMPouzols FedeMPouzols

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
2 participants
@mantid-builder @FedeMPouzols