Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacilityInfo: delete getRemoteJobManager and rearrange RemoteJob related stuff #12212

Closed
2 tasks done
mantid-builder opened this issue Mar 16, 2015 · 4 comments
Closed
2 tasks done
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 11373

Original Reporter: @FedeMPouzols

This ticket is blocked by :

getRemoteJobManager() is superseded by the RemoteJobManagerFactory (http://trac.mantidproject.org/mantid/ticket/11124).

When the remote algorithms are reorganized (http://trac.mantidproject.org/mantid/ticket/11126), FacilityInfo::getRemoteJobManager should not be needed any longer, and in general (I)RemoteJobManager should not be used in FacilityInfo.

Note: in http://trac.mantidproject.org/mantid/ticket/11126, rather than revamping the v1 remote algorithms breaking backwards compatibility, new version 2 remote algorithms have been introduced. Versions 1 still use getRemoteJobManager() and related chunks of code in FacilityInfo. So this ticket has to wait until the version 1 remove algorithms are removed (for which we could create a new ticket, or we could do it as part of this ticket).

@mantid-builder
Copy link
Collaborator Author

@NickDraper (2015-04-27T08:10:35):
Moved to R3.5 at the R3.4 code freeze

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@FedeMPouzols FedeMPouzols modified the milestones: Release 3.9, Release 3.8 Sep 22, 2016
@FedeMPouzols
Copy link
Contributor

This can only be done when/if it is safe to remove version 1 of the remote algorithms, which is being used in some SNS reduction scripts.

@FedeMPouzols FedeMPouzols removed their assignment Sep 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.9, Temporary Holding Oct 14, 2016
@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
@stale
Copy link

stale bot commented Feb 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 23, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants