Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find HDF5 headers in exotic locations #12227

Closed
mantid-builder opened this issue Mar 18, 2015 · 1 comment
Closed

Find HDF5 headers in exotic locations #12227

mantid-builder opened this issue Mar 18, 2015 · 1 comment
Assignees
Labels
Low Priority Things that you don't ever want to be done.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: @FedeMPouzols

Note: another ticket (http://trac.mantidproject.org/mantid/ticket/11359) introudced changes related to this. CMake/CommonSetup.cmake now checks for HDF5, but it turns out that a small modification is still needed to actually find the hdf5 include directories (something that only becomes an issue when the headers are not installed in /usr/include or similar).

In our cmake files we are not explicitly looking for HDF5. That is not
a big problem, as libnexus depends on it and the hdf5 headers
seem to be shipped in /usr/include on all (most) ~nix systems. But it
turns out that on debian it is possible to install different
flavors/parallel implementations of libhdf5 simultaneously. Depending
on the package that you install the headers go to different places that
require a specific additional include dir:

  • libhdf5-dev -> /usr/include/hdf5/serial/
  • libhdf5-mpi-dev libhdf5-openmpi-dev -> /usr/include/hdf5/openmpi/
  • libhdf5-mpich-dev -> /usr/include/hdf5/mpich/

So to compile mantid on debian cleanly we need to add HDF5 as a
dependency and use FindHDF5 in the cmake files to find the include dir
that is needed for libhdf5 (FindHDF5 uses h5c++ etc. to find includes
etc.).

At the moment only DataHandling/LoadSassena includes hdf5.h directly.
Well, after http://trac.mantidproject.org/mantid/ticket/11359, there are a couple more source files that include hdf5 headers.

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 11388

@mantid-builder mantid-builder added Low Priority Things that you don't ever want to be done. Tools labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Things that you don't ever want to be done.
Projects
None yet
Development

No branches or pull requests

2 participants