Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISIS SANS GUI enhancement to Diagnostics Tab #12254

Closed
Anders-Markvardsen opened this issue Mar 20, 2015 · 2 comments
Closed

ISIS SANS GUI enhancement to Diagnostics Tab #12254

Anders-Markvardsen opened this issue Mar 20, 2015 · 2 comments
Assignees
Labels
SANS Issues and pull requests related to SANS

Comments

@Anders-Markvardsen
Copy link
Member

This issue was originally TRAC 11415

Implement as described from email from Steve:

When you currently perform a horizontal or vertical integral, irrespective of what run, or range of rows/columns, you inspected, Mantid creates workspaces called

{detector}-detector-bank_H1
{detector}-detector-bank_V1

which is irritating if you want to compare different runs/ranges as you have to rename the workspaces each time before proceeding.

Please could we adopt a workspace naming more akin to that used for the reduced data, say

{runnum}-{detector}-detector-Hmin-Hmax

and similarly for V?

I realise that the range specifications can be quite complicated (and trying to implement such in a workspace name would be quite convoluted), hence I propose the above as a compromise.

The good news is that the H & V integrals do seem to be working as expected.

@Anders-Markvardsen
Copy link
Member Author

@PeterParker (2015-04-21T13:30:46):
Suggested as being a short-term "easy win" for Anton as he starts working on SANS full time.

As Steve suggests, a simple renaming is all that's necessary here, but we need to be careful that diagnostics is not expecting the current workspace naming convention to be be in place elsewhere in the code.

Anton, in the meeting today we talked about how it's not even clear what the vertical integral should mean for SANS2D. Not something to worry about in this ticket -- consider current functionality for LOQ only.

A check for system test coverage at the same time would be nice.

@AntonPiccardoSelg
Copy link
Contributor

Stephen had written earlier that the worksapce names are for example

{detector}-detector-bank_H1

I had a closer look at the code and it seems that the "detector-bank" string is part of the detector descriptor and not a separately added "noise" string. For example I integrated the data set 74019 of LOQ and found that {detector} = main-detector-bank. This means that the file name is something like {detector}_H1.

In principle we could remove the "detector-bank" part of the detector descriptor, but it seems that if this string is not longer desired, then we should remove it self-consistently across all of SANS in a separate ticket.

The ticket currently produces a workspace name of the type {runnum}-{detector}-Hmin-Hmax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

2 participants