Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to vtkStructuredGrid #12396

Closed
quantumsteve opened this issue Apr 15, 2015 · 1 comment · Fixed by #13322
Closed

Change to vtkStructuredGrid #12396

quantumsteve opened this issue Apr 15, 2015 · 1 comment · Fixed by #13322
Assignees
Labels
Framework Issues and pull requests related to components in the Framework Vates
Milestone

Comments

@quantumsteve
Copy link
Contributor

This issue was originally TRAC 11558

Utkarsh showed us how to use vtkStructuredGrid to avoid a memory copy. I temporarily removed it because the blanking arrays are not being processed by paraview at this time, but this is something we should work on early in the 3.5 release.


Keywords: vates

@quantumsteve quantumsteve added Framework Issues and pull requests related to components in the Framework Vates labels Jun 3, 2015
@quantumsteve quantumsteve self-assigned this Jun 3, 2015
@quantumsteve quantumsteve added this to the Release 3.5 milestone Jun 3, 2015
quantumsteve added a commit that referenced this issue Jul 15, 2015
quantumsteve added a commit that referenced this issue Jul 15, 2015
quantumsteve added a commit that referenced this issue Jul 17, 2015
@quantumsteve
Copy link
Contributor Author

I created a trace of creating three slices of a MDHistoWorkspace to use as a benchmark. PV and Mantid build type is RelWithDebInfo. With ParaView, I also enabled OpenGL2 and tbb. Wall times to run the script were run twice and recorded below:

master (vtkUnstructuredGrid):

real 0m14.774s
user 0m11.824s
sys 0m2.550s

real 0m14.239s
user 0m11.764s
sys 0m2.509s

vtkStructuredGrid without blanking:

real 0m13.291s
user 0m11.773s
sys 0m1.500s

real 0m13.157s
user 0m11.704s
sys 0m1.493s

vtkStructuredGrid with blanking:

real 0m24.996s
user 0m23.436s
sys 0m1.549s

real 0m24.879s
user 0m23.366s
sys 0m1.540s

vtkStructuredGrid with vtkMDHWSignalArray:

real 0m25.654s
user 0m24.096s
sys 0m1.545s

real 0m24.852s
user 0m23.371s
sys 0m1.512s

vtkStructuredGrid with vtkMDHWSignalArray and vtkMDHWPointsArray:

real 0m42.802s
user 0m41.346s
sys 0m1.434s

real 0m42.507s
user 0m41.113s
sys 0m1.425s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Vates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant