Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to select peaks by right-clicking on graph #12563

Closed
raquelalvarezbanos opened this issue May 8, 2015 · 3 comments
Closed

Add ability to select peaks by right-clicking on graph #12563

raquelalvarezbanos opened this issue May 8, 2015 · 3 comments
Assignees
Labels
Muon Issues and pull requests related to muons
Milestone

Comments

@raquelalvarezbanos
Copy link
Contributor

This issue was originally TRAC 11725

In ALC (PeakFitting step), add the ability to select peaks by right-clicking on the graph.


Keywords: ALC

@raquelalvarezbanos
Copy link
Contributor Author

@raquelalvarezbanos (2015-05-12T15:23:53):
PeakPicker tool needs to be modified to handle events even when a peak has not been set.

See lines 35-38 in MantidQt/MantidWidgets/src/PeakPicker.cpp:

  if (!m_peak)
  {
    return false; // Peak not set - nothing to do
  }

@raquelalvarezbanos raquelalvarezbanos added the Muon Issues and pull requests related to muons label Jun 3, 2015
@raquelalvarezbanos raquelalvarezbanos self-assigned this Jun 3, 2015
@raquelalvarezbanos raquelalvarezbanos added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@raquelalvarezbanos
Copy link
Contributor Author

This issue was raised by scientists because they were not aware (and neither was I) that the interface already allows to do this. Therefore, this is not an issue anymore.

To test: Open the interface: Interfaces > Muon > ALC. Read the documentation: http://docs.mantidproject.org/nightly/interfaces/Muon_ALC.html and use the example dataset used there (you can find the HIFI runs here: \ISIS\inst$\NDXHIFI\Instrument\data\cycle_13_1). When you reach the PeakFitting step, add two peaks to the function browser, select the first one (it will be highlighted in blue) press Shift and left click near the peak. A red peak picker will appear. To change the peak's width, click and drag while holding Crtl. Repeat the same steps with the second peak.

@tom-perkins
Copy link

Tested with example HIFI data as above. Added peaks to function browser.
Verified that peak positions can be set by Shift-clicking and peak width can be set by Ctrl-clicking.
Closing issue as required functionality is already present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Muon Issues and pull requests related to muons
Projects
None yet
Development

No branches or pull requests

3 participants