Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save calibration file for ENGIN-X (output from EnginXCalibrateFull) #12609

Closed
mantid-builder opened this issue May 15, 2015 · 4 comments · Fixed by #12957
Closed

Save calibration file for ENGIN-X (output from EnginXCalibrateFull) #12609

mantid-builder opened this issue May 15, 2015 · 4 comments · Fixed by #12957
Assignees
Labels
Diffraction Issues and pull requests related to diffraction
Milestone

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 11771

Original Reporter: @FedeMPouzols

This ticket is blocks : TRAC8368, TRAC11772

EnginXCalibrateFull presently produces a TableWorkspace with x-y-z values. At least we need to:

  • add more columns in the output table to show L and 2\theta, \delta L and \delta 2\theta values.
  • It may be also needed and/or convenient to save them in a different text format.
@mantid-builder mantid-builder added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.5 milestone Jun 3, 2015
@FedeMPouzols
Copy link
Contributor

From last meeting with Saurabh, it seems that it would be fine to have:
x-y-z value as is provided now + L2, 2\theta and \phi + delta L2.

Note that there's only one delta column, as L2 is the only value that changes.

@FedeMPouzols
Copy link
Contributor

Also, for now we could add an option to save this information directly into an output text file (csv). Something like OutputPositionsFilename.

@FedeMPouzols
Copy link
Contributor

As we just discussed with @Anders-Markvardsen, in addition to saving the calibration parameters in a table and a file, it would be very convenient to apply the calibration on the InputWorkspace instrument. That will be added in this issue (and explained in the EnginXCalibrateFull documentation).

@FedeMPouzols
Copy link
Contributor

The addition described in the last comment would also close issue #12700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
2 participants