Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex Shape Absorption Corrections Umbrella #12680

Closed
3 of 5 tasks
NickDraper opened this issue May 26, 2015 · 5 comments
Closed
3 of 5 tasks

Complex Shape Absorption Corrections Umbrella #12680

NickDraper opened this issue May 26, 2015 · 5 comments
Assignees
Labels
Diffraction Issues and pull requests related to diffraction Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@NickDraper
Copy link
Contributor

NickDraper commented May 26, 2015

  • Add ability to load STL files as mesh objects
  • Add ability to position mesh objects within the geometry
  • Make test script to validate using absorption corrections with simple mesh objects
  • Create script to assemble PEARL sample environment
  • Run MonteCarloAbsorption on sample environment.

PEARL scientists have provided some STL files for testing. Contact Chris Ridley@ ISIS

@NickDraper NickDraper added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal labels Jun 3, 2015
@NickDraper NickDraper added this to the Release 3.6 milestone Jun 3, 2015
@NickDraper NickDraper added Diffraction Issues and pull requests related to diffraction and removed Diffraction Issues and pull requests related to diffraction labels Jun 30, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@samueljackson92 samueljackson92 added the Low Priority Things that you don't ever want to be done. label Jul 7, 2016
@samueljackson92
Copy link
Contributor

Pascal indicated that this is currently low priority. He indicated that he wanted to perform absorption corrections on much more complicated shapes beyond what could be defined by hand. @NickDraper suggests we could do something such as limiting the flexibility of the shape geometry to be a fixed surface mesh when using a complicated shop defined from outside Mantid. More thought and discussion required when the time comes.

@samueljackson92 samueljackson92 removed this from the Release 3.8 milestone Sep 12, 2016
@samueljackson92 samueljackson92 changed the title Polyhedral shape dependent absorption corrections Complex Shape Absorption Corrections Umbrella Jan 29, 2019
@samueljackson92 samueljackson92 added Misc: Roadmap and removed Single Crystal Issues and pull requests related to single crystal labels Jan 29, 2019
@samueljackson92 samueljackson92 removed the Low Priority Things that you don't ever want to be done. label Jan 29, 2019
@samueljackson92 samueljackson92 added this to Backlog in ISIS Powder Diffraction via automation Jan 29, 2019
@samueljackson92 samueljackson92 removed their assignment Jan 29, 2019
@samueljackson92
Copy link
Contributor

@samjenkins1 has been doing some work recently to handle this. LoadSampleEnvironment now allows us to load STL files and move them to there position.

@martyngigg
Copy link
Member

The PEARL instrument scientists are going to provide us with CAD drawings of their various kits so that we can try to match the output from their own code for the corrections.

@stale
Copy link

stale bot commented Feb 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 23, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 2, 2021
Project: Powder diffraction sample correction automation moved this from To do to Done Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Stale This label is automatically applied to issues that are automatically closed by the stale bot
Development

No branches or pull requests

5 participants