Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GroupDetectors #12722

Closed
eXeC64 opened this issue Jun 2, 2015 · 0 comments · Fixed by #12765
Closed

Refactor GroupDetectors #12722

eXeC64 opened this issue Jun 2, 2015 · 0 comments · Fixed by #12765
Assignees
@eXeC64
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.5

Comments

@eXeC64
Copy link
Contributor

eXeC64 commented Jun 2, 2015

This issue was originally TRAC 11884

The command parsing could do with being more modular. Currently there's a big block of code that handles quite a lot of branching. When someone else comes to extend the syntax, it would be nicer if there were seams available to perform the extension. Even just calling some other functions for each operation would make it more readable.
@eXeC64 eXeC64 added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@eXeC64 eXeC64 self-assigned this Jun 3, 2015
@eXeC64 eXeC64 added this to the Release 3.5 milestone Jun 3, 2015
eXeC64 pushed a commit that referenced this issue Jun 8, 2015
Refs #12722 Move operators into separate functions
b7d0681
eXeC64 pushed a commit that referenced this issue Jun 8, 2015
Refs #12722 Update doc test to expose bug
42b40fc
eXeC64 pushed a commit that referenced this issue Jun 8, 2015
Refs #12722 Fix bug in range translation
ed9017b
eXeC64 pushed a commit that referenced this issue Jun 8, 2015
Refs #12722 Also cover range summation
c050ddb 
We may as wel make sure to cover *all* the syntax in the doc test, to
ensure it all works.
@eXeC64 eXeC64 mentioned this issue Jun 8, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eXeC64 eXeC64

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging a pull request may close this issue.

Refactor groupdetectors mantidproject/mantid
1 participant
@eXeC64