Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code that uses Workspace::clone(). #12949

Closed
SimonHeybrock opened this issue Jun 26, 2015 · 1 comment
Closed

Cleanup code that uses Workspace::clone(). #12949

SimonHeybrock opened this issue Jun 26, 2015 · 1 comment
Labels
Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.7

Comments

@SimonHeybrock
Copy link
Contributor

The changes in #12687 partially left cumbersome code in relation to Workspace::clone(). In particular this concerns code where the result of a clone() call is stored in a boost::shared_ptr.

clone() returns a std::unique_ptr. Boosts supports constructing a boost::shared_ptr from a std::unique_ptr starting with version 1.53. At least on Windows the current version is 1.52. Therefore, the current workaround is to initialize the boost::shared_ptr with via Workspace::clone().release(). Once we use a newer Boost version on all systems the release() call should be removed.
@SimonHeybrock SimonHeybrock added Maintenance Unassigned issues to be addressed in the next maintenance period. Framework Issues and pull requests related to components in the Framework Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Easy labels Jun 26, 2015
@SimonHeybrock SimonHeybrock added this to the Release 3.6 milestone Jun 26, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@SimonHeybrock SimonHeybrock mentioned this issue Feb 11, 2016
Merged
@SimonHeybrock
Copy link
Contributor Author

It should be possible to do this once #15448 is merged.

quantumsteve added a commit that referenced this issue Apr 18, 2016
@quantumsteve
Refs #12949. Remove release() call.
8b8460c
@quantumsteve quantumsteve mentioned this issue Apr 18, 2016
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.7
Development

No branches or pull requests
2 participants
@NickDraper @SimonHeybrock