Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty workspace title from LoadNexusProcessed (for some files) #13107

Closed
FedeMPouzols opened this issue Jul 15, 2015 · 3 comments
Closed

Empty workspace title from LoadNexusProcessed (for some files) #13107

FedeMPouzols opened this issue Jul 15, 2015 · 3 comments
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@FedeMPouzols
Copy link
Contributor

Try this:

ews=LoadNexusProcessed('ENGINX_precalculated_vanadium_bank_curves')
ews.getTitle()

And you'll get an empty title, while the file has a title. The file and the title are generated correctly with SaveNexusProcessed, but it's then lost. There's this related (very old) issue #2201, and I seem to remember some other issue(s) related to get/setTitle which I cannot find now.

The file used in the example is being added in the unit test data in another branch.

However, the title is found in other cases:

ews=LoadNexusProcessed('GEM38370_Focussed.nxs')
ews.getTitle()
# work well

Maybe it's because ENGINX_precalculated_vanadium_bank_curves does not have an instrument (it comes from a Fit)?

A quick look at the code took me to line 200 in LoadNexusProcessed.cpp, as they discuss in #2201, now around line 260.

@FedeMPouzols FedeMPouzols added the Framework Issues and pull requests related to components in the Framework label Jul 15, 2015
@FedeMPouzols FedeMPouzols added this to the Release 3.5 milestone Jul 15, 2015
@FedeMPouzols
Copy link
Contributor Author

This seems to be very closely related to #11386.

@NickDraper
Copy link
Contributor

Current warnings in the Rhel 7 clean master build are as follows

01:45:12 
01:45:12 /home/builder/Jenkins/workspace/master_clean-rhel7/docs/source/algorithms/LRAutoReduction-v1.rst:18: WARNING: undefined label: algm-liquidsreflectometryreduction (if the link has no caption the label must precede a section header)
01:45:12 /home/builder/Jenkins/workspace/master_clean-rhel7/docs/source/concepts/MatrixWorkspace.rst:372: WARNING: undefined label: plus (if the link has no caption the label must precede a section header)
01:45:12 /home/builder/Jenkins/workspace/master_clean-rhel7/docs/source/concepts/Properties.rst:179: WARNING: undefined label: algm-propertyalgorithm (if the link has no caption the label must precede a section header)
01:45:12 /home/builder/Jenkins/workspace/master_clean-rhel7/docs/source/concepts/WorkflowAlgorithm.rst:44: WARNING: undefined label: algm-muonload (if the link has no caption the label must precede a section header)
01:45:12 writing additional files... genindex py-modindex search

@NickDraper NickDraper self-assigned this Feb 18, 2016
NickDraper added a commit that referenced this issue Feb 18, 2016
@NickDraper NickDraper removed their assignment Feb 18, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@NickDraper NickDraper modified the milestones: Release 3.8, Release 3.9 Oct 3, 2016
@NickDraper NickDraper removed this from the Release 3.9 milestone Oct 14, 2016
@NickDraper NickDraper modified the milestones: Temporary Holding, Release 3.9 Oct 14, 2016
@NickDraper
Copy link
Contributor

duplicate of #11386

@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

3 participants