Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend functionality of instrument view with PeaksWorkspace #13908

Closed
4 of 5 tasks
MichaelWedel opened this issue Oct 8, 2015 · 3 comments
Closed
4 of 5 tasks

Extend functionality of instrument view with PeaksWorkspace #13908

MichaelWedel opened this issue Oct 8, 2015 · 3 comments
Assignees
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@MichaelWedel
Copy link
Contributor

This results from a discussion with Pascal Manuel.

At WISH a common step is to use PredictPeaks to get a PeaksWorkspace with predicted reflections. This workspace is then dragged onto the instrument view, where the peak positions are indicated by small filled circles. Pascal suggested that it would be very useful to have an approximate indication for the expected peak intensity. This may also be useful for other single crystal diffractometers.

Implementing this requires several tasks that can be done independently:

@MichaelWedel MichaelWedel added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal labels Oct 8, 2015
@MichaelWedel MichaelWedel added this to the Release 3.6 milestone Oct 8, 2015
@MichaelWedel MichaelWedel self-assigned this Oct 8, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@MichaelWedel MichaelWedel modified the milestones: Release 3.7, Release 3.8 May 18, 2016
@NickDraper NickDraper modified the milestones: Release 3.8, Release 3.9 Oct 3, 2016
@NickDraper NickDraper modified the milestones: Release 3.9, Temporary Holding Oct 14, 2016
@NickDraper NickDraper modified the milestones: Temporary Holding, Release 3.11 Oct 3, 2017
@martyngigg
Copy link
Member

I believe this is now done as both the slice viewer and instrument view show the required information for single crystal peaks.

@stale
Copy link

stale bot commented Feb 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 23, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants