Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions for saving/loading a calibration table to Tube calibration #17410

Closed
samueljackson92 opened this issue Sep 6, 2016 · 2 comments
Closed

Add functions for saving/loading a calibration table to Tube calibration #17410

samueljackson92 opened this issue Sep 6, 2016 · 2 comments
Assignees
@samueljackson92
Milestone
Release 3.8

Comments

@samueljackson92
Copy link
Contributor

samueljackson92 commented Sep 6, 2016 •
edited

Tube calibration produces a workspace of peaks and a calibration table workspace. In tube.py we have already have functions readPeakFile and savePeakFile. We should create the corresponding definitions for the calibration table.

This is a sub issue of #12678.
@samueljackson92 samueljackson92 added this to the Release 3.8 milestone Sep 6, 2016
@samueljackson92 samueljackson92 self-assigned this Sep 6, 2016
@samueljackson92
Copy link
Contributor Author

This calibration module could use a set of unit tests. I've created #17411 to deal with that as a separate maintenance task.

samueljackson92 added a commit that referenced this issue Sep 6, 2016
@samueljackson92
Refs #17410 Add save/load function for calibration table
b778147
samueljackson92 added a commit that referenced this issue Sep 6, 2016
@samueljackson92
Refs #17410 Add item to release notes
b3116a2
samueljackson92 added a commit that referenced this issue Sep 6, 2016
@samueljackson92
Refs #17410 Fix some linter warnings
da484d7
@raquelalvarezbanos
Copy link
Contributor

This was fixed in PR #17414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samueljackson92 samueljackson92

Labels
None yet
Projects
None yet
Milestone
Release 3.8
Development

No branches or pull requests
2 participants
@samueljackson92 @raquelalvarezbanos