Add DynamicKuboToyabe fitting function #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace CurveFitting | ||
| { | ||
| /** | ||
| Provide Dynamic Kubo Toyabe function interface to IPeakFunction for muon scientists. |
There was a problem hiding this comment.
This isn't an IPeakFunction, could you correct the comment
|
|
||
|
|
||
| // Zero hopping rate | ||
| if (v == 0.0) { |
There was a problem hiding this comment.
very confusing indentation here on this line and the ones below, could you try running clang on this? or fix it yourself
|
Functionally fine, but needs some neatening up in the code |
|
Thanks for your comments, Nick. I will update the code according to your suggestions. |
NickDraper
added a commit
that referenced
this pull request
Feb 20, 2015
Add DynamicKuboToyabe fitting function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes trac issue #9556
For tester: Open the muon analysis interface and load one of the muon datasets attached in the trac ticket. Set Alpha=0.96 in the first row in "Pair Table", in "Grouping Options" tab, and hit "Plot". Go to "Data Analysis" and add "DynamicKuboToyabe" fitting function. You should be able to obtain a good fit if you fix the Field parameter to 0 (otherwise an exception will be raised, as the DKT function for non-zero magnetic field will be implemented in ticket #11086). Play with different fitting ranges and the other dataset attached.