Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptRepo now works with the new internetHelper #238

Merged
merged 4 commits into from Feb 19, 2015

Conversation

NickDraper
Copy link
Contributor

Ticket http://trac.mantidproject.org/mantid/ticket/11069

To Test

  1. Use the script repository
  2. Download plenty of files
  3. Upload a file
    1. By default it is setup to load from the live repo, but upload to a seperate one, so you should get success, but if you refresh the dialog you will get the icon reset as if it was not uploaded.
  4. Delete a file
    1. By default it is setup to load from the live repo, but upload to a seperate one, so you should get success, but if you refresh the dialog you will get the icon reset as if it was not uploaded.

@DanNixon DanNixon added this to the Release 3.4 milestone Feb 18, 2015
@DanNixon DanNixon self-assigned this Feb 18, 2015
@DanNixon
Copy link
Member

Seems that there is a build warning coming from ScriptRepositoryImpl.cpp.

DanNixon added a commit that referenced this pull request Feb 19, 2015
…o_use_InternetHelper

ScriptRepo now works with the new internetHelper
@DanNixon DanNixon merged commit 2e32c70 into master Feb 19, 2015
@DanNixon DanNixon deleted the feature/11069_ScriptRepo_to_use_InternetHelper branch February 19, 2015 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants