Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test for ConvertToMatrixWorkspace #2899

Closed
stuartcampbell opened this issue Dec 10, 2010 · 3 comments
Closed

Improve unit test for ConvertToMatrixWorkspace #2899

stuartcampbell opened this issue Dec 10, 2010 · 3 comments
Assignees
@MattKing06
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done. Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.5

Comments

@stuartcampbell
Copy link
Collaborator

This issue was originally TRAC 2052

At the moment the test is just a copy of CloneWorkspace(), it really needs to test that the histogram representation of an event workspace is being copied out correctly.

Keywords: Maintenance
@stuartcampbell
Copy link
Collaborator Author

@NickDraper (2010-12-16T09:49:26):
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

@NickDraper (2011-02-15T09:09:32):
Bulk move of tickets at the end of iteration 27

@NickDraper (2011-04-27T07:36:00):
Bulk move of tickets at the end of iteration 28

@NickDraper (2011-09-19T09:30:53):
Bulk move of tickets to iteration 31 at the iteration 30 code freeze

@NickDraper (2012-01-09T09:43:30):
Moved to iteration 33 at iteration 32 code freeze

@NickDraper (2012-04-30T14:14:07):
Moved at end of release 2.1

@NickDraper (2012-08-10T12:44:01):
Moved at the end of release 2.2

@NickDraper (2012-10-28T11:39:14):
Moved to milestone 2.4

@NickDraper (2013-01-28T09:23:24):
Moved at the code freeze for release 2.4

@NickDraper (2013-04-29T09:50:01):
Moved to r2.6 at the end of r2.5

@NickDraper (2013-07-26T13:55:02):
Moved to backlog at the code freeze for R2.6

@NickDraper (2014-02-14T11:07:56):
bulk move to assigned at the into of the triage step

@stuartcampbell stuartcampbell added Low Priority Things that you don't ever want to be done. Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@Anders-Markvardsen
Copy link
Member

Add unit test to ConvertToMatrixWorkspaceTest that shows that the histogram representation of an event workspace matches that of the histogram in the created MatrixWorkspace from this algorithm

@martyngigg martyngigg added this to the Release 3.5 milestone Jul 13, 2015
@martyngigg
Copy link
Member

It would seem that this has been done at some point. However, the test can still be improved. It uses a file and that can be removed in favour of an in-memory workspace.

MattKing06 added a commit that referenced this issue Jul 14, 2015
@MattKing06
Edited ConvertToMatrixWorkspaceTest.h
108c511 
Changed header file to use in-memory workspace instead of file

Refs #2899
MattKing06 added a commit that referenced this issue Jul 14, 2015
@MattKing06
Cleaned up code in ConvertToMatrixWorspace.h
2c3bf23 
Reduced dependencies on name spaces and ordered header files to comply with
coding standards

Refs #2899
@MattKing06 MattKing06 mentioned this issue Jul 14, 2015
Merged
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 Changes made from suggestions in comments
7e95763 
Removed any redundant includes from ConvertToMatrixWorkspace.h.
Changed any use of AnalysisDataService to use Mantid::API::Algorithm instead
Reformatted using Clang format
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 Replaced Tabs with spaces
112796e 
forgot to do this before formatting with clang
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 Created message for TSM_ASSERT_EQUALS in loop
fb2d06f 
Changed from TS_ASSERT_EQUALS to TSM_ASSERT_EQUALS and involved the loop
variant in the failure message to identify which Histogram produced the error.
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 changed TSM_ASSERT message: convert int to string
07e4593 
Convert int to string in such a way that RHEL6/7 are happy with the conversion
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 Changed method of convert int to string
2deb796
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Refs #2899 used lexical_cast to convert int to string
5ed81bf
MattKing06 added a commit that referenced this issue Jul 16, 2015
@MattKing06
Reverted ToFConverter files back to master
2f7b986 
Refs #2899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattKing06 MattKing06

Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.5
Development

No branches or pull requests
4 participants
@stuartcampbell @martyngigg @Anders-Markvardsen @MattKing06