Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The peak picking tool should work for ineslatic, direct and indirect #4021

Closed
NickDraper opened this issue Jun 13, 2011 · 1 comment
Closed

The peak picking tool should work for ineslatic, direct and indirect #4021

NickDraper opened this issue Jun 13, 2011 · 1 comment
Assignees
@mantid-roman
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Iteration 30

Comments

@NickDraper
Copy link
Contributor

At the moment the results are only right for elastic experiments. This is because the setting for the unit conversion energy mode is set that way.

Also the tool should work in any unit, not just TOF. This means using the unit code in Mantid.

Perform a lookup for the detector for some Params:

If it has an Ei param - Direct
If it has an Efixed param - Indirect
otherwise - elastic

Check the names and casing of the param names in ConvertUnits.

This decision code should be with the unit code somewhere as it is likely to be of wider use in the future.
@NickDraper
Copy link
Contributor Author

This issue was originally trac ticket 3174

@NickDraper NickDraper added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Mantid labels Jun 3, 2015
@NickDraper NickDraper added this to the Iteration 30 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantid-roman mantid-roman

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Iteration 30
Development

No branches or pull requests
2 participants
@NickDraper @mantid-roman