New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability of CreateSampleShape GUI #4584
Comments
@NickDraper (2012-01-09T09:43:02): @NickDraper (2012-04-30T14:12:09): @NickDraper (2012-08-10T12:43:26): @NickDraper (2012-10-28T11:38:40): @NickDraper (2013-01-28T09:22:53): @NickDraper (2013-04-29T09:49:33): @martyngigg (2013-06-18T14:35:31): Keith Brown (2013-07-15T09:54:05):
Keith Brown (2013-07-16T13:45:16): The program should no longer freeze as it is no longer possible to update Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-07-17T12:21:16): Validation has had a fix as in the shape valid() methods I had negated some conditions when I shouldn't have. Otherwise, work is starting on loading a stored shape Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-07-18T15:17:43): The XML parser has been started and currently only gets the algebra string so that the tree can be constructed. Next job is to actually build a data structure to hold the tree info in Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-07-19T09:29:42): Committing to save progress before looking at another branch Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-07-19T15:58:01): the recursive equation parsing algorithm is taking shape and the framework is nealry complete Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-07-22T13:59:18): The parsing function is as complete as it can be for now, as it can't create anything before i supply the storage framework for storing the dummy tree Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-08-16T11:21:43): Will have to change either the map or strip out the # before looking it up. Keith Brown (2013-08-21T08:17:07): Now creating the functionality to populate the tree. Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-08-21T08:17:08): The instanciation methods that build the QTreeWidget are taking shape. I've added new constructors to ShapeDetails and derived classes that take a Poco::XML::Element and can fill in details from the XML contained within that element Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-08-21T08:17:08): The tree is being built as expected and the XML is being parsed, but i've revealed that the new way i've done something seems to mean that widgets aren't being loaded, but i'll fix that by making it get the widget a more sensible way. Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-08-21T16:04:53): At least spheres and finite cylinders import properly, the code is there for sliceofcylinderring and infinitecylinder but they've not been tested. The other shapes are awaiting parseing code. I had made some mistakes when it came to complements of shapes. The first was that even if they were identified they weren't getting set as them, this was because I'd accidentally redeclared the flag as local and it was going out of scope. the second was that the displayed text was wrong due to the way i was constructing the QString. Fixed a possible memory leak (or at least objects were kept in memory and not deleted) as when i was parsing XML in the shapes, some lists weren't being released. Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2013-08-22T13:22:20): All shapes now have a construtor that will intialise them from XML. I still need to inlcude parts for the spherical coordinate system but once that's in all i need to do is test it out and make sure it works fully Refs http://trac.mantidproject.org/mantid/ticket/3737 Keith Brown (2014-06-18T07:42:24): Keith Brown (2014-06-26T13:17:41): There is work against this ticket on branch bugfix/3737_CreateSampleShape_freeze_and_load_fix |
not frequently used- archived |
This issue was originally TRAC 3737
This ticket is blocked by :
The gui can cause Mantid to crash when insufficient information is present to display the sample.
e.g.
The text was updated successfully, but these errors were encountered: