Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore erroneously commented out MantidPlot virtual methods #4590

Closed
mantid-builder opened this issue Sep 19, 2011 · 1 comment
Closed

Restore erroneously commented out MantidPlot virtual methods #4590

mantid-builder opened this issue Sep 19, 2011 · 1 comment
Milestone
Iteration 30

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

I failed to use my brain when commenting out a bunch of methods that caused Intel compiler warnings. I blindly trusted Eclipse when it told me the methods weren't called without thinking how virtual methods work, and how Eclipse doesn't know about the third party source code.

The fix to http://trac.mantidproject.org/mantid/ticket/3731 involved restoring on such method - I should put back the other places I did this and worry about the warnings later.
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 3743

@mantid-builder mantid-builder added this to the Iteration 30 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iteration 30
Development

No branches or pull requests
1 participant
@mantid-builder