Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked bins are not accounted for in DiffractionFocussing for event workspaces #4892

Closed
martyngigg opened this issue Nov 2, 2011 · 4 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@martyngigg
Copy link
Member

This issue was originally TRAC 4045

From MantidHelp:

I am trying to remove the WISH prompt pulse with the MaskBins algorithm using both event nxs file and raw file generated from the event nxs one (a python script with the history is in the attachment). Surprisingly, the MaskBins algorithm works differently for the nxs and raw files (see the attached screenshot with the plotted result). Do you have an idea why it is like that? and how to improve the prompt pulse removing in the case of event nxs files?

The problem is that for event workspaces the events are physically removed but not kept track of so that the normalization in DiffractionFocussing is too high. See attached plot and script.

@martyngigg
Copy link
Member Author

Russell Taylor (2011-11-02T18:49:24):
Kind of related to this, it looks to me as though masked ''detectors'' are not accounted for when calculating the normalizing weight when you have a Workspace2D (they are for events).


@NickDraper (2012-01-09T09:43:12):
Moved to iteration 33 at iteration 32 code freeze


@NickDraper (2012-04-30T14:12:26):
Moved at end of release 2.1


@NickDraper (2012-08-10T12:43:30):
Moved at the end of release 2.2


@NickDraper (2012-10-28T11:38:43):
Moved to milestone 2.4


@NickDraper (2013-04-29T09:49:35):
Moved to r2.6 at the end of r2.5


@NickDraper (2013-07-26T13:54:58):
Moved to backlog at the code freeze for R2.6


@NickDraper (2014-02-14T11:04:55):
Bulk move to assigned at the introduction of the triage step

@martyngigg
Copy link
Member Author

@martyngigg martyngigg added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

2 participants