Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SANS: make ISISReducer and SANSReducer same attributes where possible #4910

Closed
Anders-Markvardsen opened this issue Nov 4, 2011 · 1 comment
Closed

SANS: make ISISReducer and SANSReducer same attributes where possible #4910

Anders-Markvardsen opened this issue Nov 4, 2011 · 1 comment
Labels
Low Priority Things that you don't ever want to be done. SANS Issues and pull requests related to SANS
Milestone
Release 3.2

Comments

@Anders-Markvardsen
Copy link
Member

Confusingly the ISISReducer currently use different attributes to store same information. For instance SANSReducer stores masking in _mask. This attributes also set for ISISReducer but in addition masking stored in attribute named mask.

When getting time to look at this - discuss with Mathieu. Also the init of SANSReducer may benifit from being split up into part deals with SANS in general and part which deals with SNS/HFIR only.
@Anders-Markvardsen
Copy link
Member Author

This issue was originally trac ticket 4063

@Anders-Markvardsen Anders-Markvardsen added Low Priority Things that you don't ever want to be done. SANS Issues and pull requests related to SANS labels Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low Priority Things that you don't ever want to be done. SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@Anders-Markvardsen