ConjoinWorkspaces: validateInputs is not called for event workspaces

[mantid-builder]

This issue was originally TRAC 4717

Original Reporter: Russell Taylor

Meaning that the check that both workspaces come from the same instrument, and have the same units is done for Workspace2Ds but not for EventWorkspaces.

[mantid-builder]

@NickDraper (2012-04-30T14:15:46):
Moved at end of release 2.1

---

@NickDraper (2012-08-10T12:45:12):
http://www.mantidproject.org/Release_Notes_2_2_Full_List

---

@NickDraper (2012-10-28T11:42:52):
Moved to release 2.4

---

@NickDraper (2013-01-28T09:23:33):
Moved at the code freeze for release 2.4

---

@NickDraper (2013-04-29T09:50:06):
Moved to r2.6 at the end of r2.5

---

@NickDraper (2013-07-26T13:59:10):
Moved to the Backlog after the code freeze for R2.6

---

@NickDraper (2014-02-14T11:07:57):
bulk move to assigned at the into of the triage step

[NickDraper]

This is the code you want to look for

if (event_ws1 && event_ws2) {
    // We do not need to check that binning is compatible, just that there is no
    // overlap
    // make sure we should bother checking
    if (this->getProperty("CheckOverlapping")) {
      this->checkForOverlap(*event_ws1, *event_ws2, false);
      m_overlapChecked = true;
    }

    // Both are event workspaces. Use the special method
    MatrixWorkspace_sptr output = this->execEvent();
    // Copy the history from the original workspace
    output->history().addHistory(ws1->getHistory());
    // Delete the second input workspace from the ADS
    AnalysisDataService::Instance().remove(getPropertyValue("InputWorkspace2"));
    // Set the result workspace to the first input
    setProperty("InputWorkspace1", output);
    return;
  }

  // Check that the input workspaces meet the requirements for this algorithm
  this->validateInputs(*ws1, *ws2);

1. Create a failing unit test
2. Fix
3. Happy passing unit test