Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParameterMap: Speed up the way masked detectors are recorded (?) #5606

Closed
mantid-builder opened this issue Feb 7, 2012 · 2 comments
Closed
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 4759

Original Reporter: @jzikovsky

Instead of using a "masked" string with key = detector pointer, I suggest that we record masked detectors in the ParameterMap with a simple map:

  • Key = detector ID (not the component ID)
  • Value = true if Masked, false if not masked.

Or, even faster would be a vector, which can be accessed in O(1) time instead of O(log(N)) time.

A third option is to hold a std::set<> of masked detector IDs. Looking them up will be very fast when few detectors are masked, and at worst O(log(N)) if most detectors are masked. It is also safer than the vector (no going out of bounds).

This should speed up instrument view (and others) significantly. Plotting TOPAZ takes 1000 msec + each time it redraws. 800 msec or so are spent looking for masked detectors.

@mantid-builder
Copy link
Collaborator Author

@NickDraper (2012-04-30T14:15:47):
Moved at end of release 2.1


@NickDraper (2012-08-10T12:45:13):
http://www.mantidproject.org/Release_Notes_2_2_Full_List


@NickDraper (2012-10-28T11:42:52):
Moved to release 2.4


@NickDraper (2013-04-29T09:50:06):
Moved to r2.6 at the end of r2.5


@NickDraper (2013-07-26T13:59:10):
Moved to the Backlog after the code freeze for R2.6


@NickDraper (2014-02-14T11:07:57):
bulk move to assigned at the into of the triage step

@mantid-builder mantid-builder added Low Priority Things that you don't ever want to be done. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@NickDraper
Copy link
Contributor

archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Projects
None yet
Development

No branches or pull requests

2 participants