Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Ensure include paths have only what is necessary for each target #6613

Closed
mantid-builder opened this issue Aug 16, 2012 · 1 comment
Closed
Labels
Low Priority Things that you don't ever want to be done.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

Because of the fact that an include_directories command in CMake has file scope (so targets will pick such a command up even if it comes later in the CMakeLists), many of our libraries have extra directories in the path that are required for the unit tests. The solution is to add CMakeLists files to all out test directories and move the creation of the test executable targets to there.

We also have things (e.g. Qt) that are added to the include path for everywhere when they should be added only for those targets that need them.

Doing this will mean that trying to use something that isn't a dependency will be picked up sooner.

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 5767

@mantid-builder mantid-builder added Low Priority Things that you don't ever want to be done. Mantid labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 2.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Things that you don't ever want to be done.
Projects
None yet
Development

No branches or pull requests

1 participant