Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mechanism to check Ui generated classes don't have the same name #6759

Closed
martyngigg opened this issue Oct 5, 2012 · 1 comment
Closed

Add mechanism to check Ui generated classes don't have the same name #6759

martyngigg opened this issue Oct 5, 2012 · 1 comment
Assignees
@martyngigg
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 2.6

Comments

@martyngigg
Copy link
Member

It was recently discovered, [5911], that when generating classes with the Qt designer it is possible to have name clashes that are not picked up by the compiler. This can cause runtime failures when the incorrect classes are used within a custom dialog.

It should be possible to use CMake to generate an articifial cpp file that simply includes all of the ui_* headers to check whether it compiles. If not, there is a name clash and and something needs to be changed.

This would be better than discovering this at runtime.

Keywords: Maintenance
@martyngigg
Copy link
Member Author

This issue was originally trac ticket 5913

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg martyngigg added this to the Release 2.6 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martyngigg martyngigg

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 2.6
Development

No branches or pull requests
1 participant
@martyngigg