Workspace list shows invisible workspaces when next visible is created

[martyngigg]

This issue was originally TRAC 5952

To reproduce:

• Go to View->Preferences->Mantid->Options and uncheck "show invisible workspaces"
• Click Load;
• Pick a file and prefix the suggested workspace name with __
• The algorithm will run but there should be nothing in the list
• Click load again and run the same thing but without the prefix. The invisible workspace will appear alongside the visible after the algorithm completes

[martyngigg]

@NickDraper (2012-10-26T09:47:24):
Actually the script above does work, however when you check or uncheck the "show invisible workspaces" it does not refresh the workspace list. The status visibility of the workspace depends on the value of the flag when the workspace was created.

This could be improved by having the workspace display update if the flag is changed.

---

@NickDraper (2012-10-28T11:42:57):
Moved to release 2.4

---

@NickDraper (2013-01-28T09:25:13):
Moved at the code freeze for release 2.4

---

@NickDraper (2013-04-29T09:50:09):
Moved to r2.6 at the end of r2.5

---

@NickDraper (2013-07-26T13:59:11):
Moved to the Backlog after the code freeze for R2.6

---

@NickDraper (2014-02-14T11:07:57):
bulk move to assigned at the into of the triage step

[FedeMPouzols]

This is still an issue. If you go to Edit->Preferences->Mantid->Options and set "Show invisible workspaces", then "apply", you won't see them. If for example you reload the invisible workspace as invisible ("_") then you will see it.

[FedeMPouzols]

@NickDraper: this could be another good "anyone" ticket for new starters.

[PranavBahuguna]

Could you briefly explain how in the code, checking/unchecking the "Show invisible workspaces" option causes the workspaces dock (MantidDock.cpp) to hide or unhide workspaces in the first place?

[PranavBahuguna]

On the previous commit, I have changed ConfigDialog::updateMantidOptionsTab to have MantidDock::updateTree called - the method responsible for hiding or unhiding workspaces. I have noticed however that updateTree() is intended to only be called when the GUI thread is free, and I assume this means that no other windows like the preferences window could be open when updateTree() is called. Is there any good reason why this is so? Without this restriction, I could hide/unhide workspaces on clicking the apply button in a similar manner as to algorithm categories in the dock can be made visible or not by toggling their checkboxes in the Preferences window,