Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a facility from Facilities.xml file does not complete kill it #6921

Closed
martyngigg opened this issue Nov 1, 2012 · 1 comment
Closed

Removing a facility from Facilities.xml file does not complete kill it #6921

martyngigg opened this issue Nov 1, 2012 · 1 comment
Assignees
@FedeMPouzols
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.4

Comments

@martyngigg
Copy link
Member

Currently if you remove a facility from the Facilities.xml file but not from the 'supported.facilities' and start Mantid it complains about the missing facility (This was seen on LET that didn't have LENS in a different Facilties file it was using).

The error comes from MultiFileNameParser.cpp:212 where it uses the supported.facilities to iterate over facilities but doesn't find the one that has been taken out of the XML file.

The 'supported.facilities' property predates the Facilties.xml file and needs removing as it is now only a source of duplicate information. We can get everything from the Facilities file.

We need to make sure we find all of the places in the code that use the property and update them
@martyngigg
Copy link
Member Author

This issue was originally trac ticket 6075

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FedeMPouzols FedeMPouzols

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.4
Development

No branches or pull requests
2 participants
@martyngigg @FedeMPouzols