Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Muon IDFs to use locations tag #7029

Closed
NickDraper opened this issue Nov 19, 2012 · 3 comments
Closed

Adjust Muon IDFs to use locations tag #7029

NickDraper opened this issue Nov 19, 2012 · 3 comments
Assignees
Labels
Low Priority Things that you don't ever want to be done. Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons

Comments

@NickDraper
Copy link
Contributor

As demonstrated in comment below: Arturs Bekasovs (2014-03-25T10:04:48): for the Muon instruments Musr, EMU, ARGUS and HIFI use to make IDFs for these instrument shorter.

For document on IDFs see http://docs.mantidproject.org/nightly/concepts/InstrumentDefinitionFile.html

Make these changes and check that detectors are still in the same positions.

@NickDraper
Copy link
Contributor Author

@NickDraper (2013-01-28T09:23:20):
Moved at the code freeze for release 2.4


@NickDraper (2013-04-29T09:49:53):
Moved to r2.6 at the end of r2.5


@NickDraper (2013-07-26T13:55:00):
Moved to backlog at the code freeze for R2.6


@NickDraper (2014-02-28T16:53:48):
Please assess if ticket is still valid and add a description to the ticket


@Anders-Markvardsen (2014-03-03T16:18:57):
This was meant as a maintenance ticket.

Many of the IDFs could likely become a lot shorter by using the <locations> tag to replace equilly spaced <location> tags.

At this point I have done this for LET, which described here, http://www.mantidproject.org/IDF#Using_.3Clocations.3E , reduced IDF from 1590 to 567 lines.

It is not a high priority, and perhaps rather than doing a mass conversion of all IDFs as suggested with this ticket, just convert IDF on case by case basis and where users can benefit from a shorter IDF.

Hence, writing this I am indifferent as to whether or not to close this ticket.


Arturs Bekasovs (2014-03-25T10:04:48):
While working on http://trac.mantidproject.org/mantid/ticket/9136, I've found another example of potential space for improvements. It's the MUSR definition:

  `<type name="ring-front">`
    `<component type="pixel">`
    `<location r="0.14" t="90" p="309.375000" rot="309.375000" name="det33"/>`    
    `<location r="0.14" t="90" p="298.125000" rot="298.125000" name="det34"/>`
    `<location r="0.14" t="90" p="286.875000" rot="286.875000" name="det35"/>`
    ... more lines ...
    `<location r="0.14" t="90" p="28.125000" rot="28.125000" name="det58"/>`
    `<location r="0.14" t="90" p="16.875000" rot="16.875000" name="det59"/>`
    `<location r="0.14" t="90" p="5.625000" rot="5.625000" name="det60"/>`
    `<location r="0.14" t="90" p="354.375000" rot="354.375000" name="det61"/>`
    `<location r="0.14" t="90" p="343.125000" rot="343.125000" name="det62"/>`
    `<location r="0.14" t="90" p="331.875000" rot="331.875000" name="det63"/>`
    `<location r="0.14" t="90" p="320.625000" rot="320.625000" name="det64"/>`
    `</component>`    
  `</type>`  

This might be replaced with much shorter (and consequently less error-prone):

  `<type name="ring-front">`
    `<component type="pixel">`
      `<locations r="0.14" t="90" p="309.375000" p-end="5.625000" rot="309.375000" rot-end="5.625000" name="det" n-elements="28" name-count-start="33"/>`
      `<locations r="0.14" t="90" p="354.375000" p-end="320.625000" rot="354.375000" rot-end="320.625000" name="det" n-elements="4" name-count-start="61"/>`
    `</component>`
  `</type>`  

I believe that EMU, ARGUS and HIFI have similar structures as well.


@NickDraper (2015-03-02T11:57:13):
Set to new at the end of Triage

@NickDraper NickDraper added Low Priority Things that you don't ever want to be done. Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen changed the title Adjust existing definitions to use locations tag Adjust Muon IDFs to use locations tag Jul 10, 2015
@Anders-Markvardsen Anders-Markvardsen added Muon Issues and pull requests related to muons and removed Framework Issues and pull requests related to components in the Framework labels Jul 10, 2015
@Anders-Markvardsen
Copy link
Member

@tom-perkins would you be OK if I reassign this issue to you or you reassign it to yourself. I still think it is worth having this issue in the backlog for a rainy day

@Anders-Markvardsen
Copy link
Member

Hi @AnthonyLim23 had this issue in my list. It is a maintenance issue which as learning exercise, to learn how we describe IDFs, I would recommend you have a go at early in the next release cycle. If you have any question concerning IDFs don't hesitate to find me also.

@Anders-Markvardsen Anders-Markvardsen added this to the Release 3.10 milestone Jan 12, 2017
@NickDraper NickDraper modified the milestones: Release 3.10, Release 3.11 May 23, 2017
@NickDraper NickDraper removed this from the Release 3.11 milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Things that you don't ever want to be done. Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
None yet
Development

No branches or pull requests

4 participants