Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship instrument vtp files with installers #7107

Closed
martyngigg opened this issue Dec 3, 2012 · 2 comments
Closed

Ship instrument vtp files with installers #7107

martyngigg opened this issue Dec 3, 2012 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.

Comments

@martyngigg
Copy link
Member

This issue was originally TRAC 6261

This ticket is blocks : TRAC7908

We currently ship (accidentally) the .vtp files for the instruments that happen to have the unit tests run on them. Ship them for each definition that we ship

@martyngigg
Copy link
Member Author

@NickDraper (2013-04-29T09:49:28):
Moved to r2.6 at the end of r2.5


@martyngigg (2013-07-15T08:46:43):
Batch move to 2.7


@NickDraper (2013-08-02T15:35:58):
Poker Estimate: 3d


Russell Taylor (2013-09-10T18:58:44):
(In http://trac.mantidproject.org/mantid/ticket/7908) Something deep within OpenCascade concerning the writing of the vtp files is scuppering me here - it's locking up for some reason.

Re-visit this after http://trac.mantidproject.org/mantid/ticket/6261 is done. In fact, that will likely remove most of the benefit of this ticket anyway as most of the time is in generating these files. Here are the timings on my machine:

  • Parallel, not writing vtp files: 21s
  • Not parallel, vtp files there: 95s
  • Not parallel, writing vtp files: 20 minutes

@NickDraper (2013-10-15T15:41:03):
Moved out to backlog as not enough time in R3.0


@NickDraper (2014-02-14T11:04:53):
Bulk move to assigned at the introduction of the triage step

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg
Copy link
Member Author

Given that the vtp files are now generated outside in the user config directory and we have instrument downloading I think the benefits of this are quite small now.

We could choose to revisit this if it becomes and issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant