Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event filtering items #7194

Closed
peterfpeterson opened this issue Jan 9, 2013 · 1 comment
Closed

Event filtering items #7194

peterfpeterson opened this issue Jan 9, 2013 · 1 comment
Assignees
Labels
Low Priority Things that you don't ever want to be done.
Milestone

Comments

@peterfpeterson
Copy link
Member

These tasks were discovered when using SEQ_31276.

For FilterEventsHighFrequency

  • Have it inherit from DeprecatedAlgorithm rather than just having a comment in the algorithm description
    For GenerateEventsFilter:
  • The TimeType variable is unclear in its usage/meaning
  • When splitting using SampleTemp from 276 to 288 in steps of 1, the tables generated start at 275.5 degrees rather than 276.
  • Change the name of the parameter SplittersInformationWorkspace to InformationWorkspace
  • Both the OutputWorkspace and the SplittersInformationWorkspace should agree on the common column heading of WorkspaceGroup and the values should match rather than be one off (information starts from zero, output starts from one)
  • For the run being used, there are several rows in the OutputWorkspace that have zero time between the start and stop (rows 3 through 7 in my test). They should not appear.
    For FilterEvents
  • Events that are not filtered should go into a workspace named OutputWorkspaceBaseName_unfiltered
  • Similar to GenerateEventsFilter, change the name of SplittersInformationWorkspace
  • Change InputSplittersWorkspace to SplitterWorkspace
@peterfpeterson peterfpeterson added Low Priority Things that you don't ever want to be done. Mantid labels Jun 3, 2015
@peterfpeterson
Copy link
Member Author

This issue was originally trac ticket 6348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Things that you don't ever want to be done.
Projects
None yet
Development

No branches or pull requests

2 participants