You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have it inherit from DeprecatedAlgorithm rather than just having a comment in the algorithm description
For GenerateEventsFilter:
The TimeType variable is unclear in its usage/meaning
When splitting using SampleTemp from 276 to 288 in steps of 1, the tables generated start at 275.5 degrees rather than 276.
Change the name of the parameter SplittersInformationWorkspace to InformationWorkspace
Both the OutputWorkspace and the SplittersInformationWorkspace should agree on the common column heading of WorkspaceGroup and the values should match rather than be one off (information starts from zero, output starts from one)
For the run being used, there are several rows in the OutputWorkspace that have zero time between the start and stop (rows 3 through 7 in my test). They should not appear.
For FilterEvents
Events that are not filtered should go into a workspace named OutputWorkspaceBaseName_unfiltered
Similar to GenerateEventsFilter, change the name of SplittersInformationWorkspace
Change InputSplittersWorkspace to SplitterWorkspace
The text was updated successfully, but these errors were encountered:
These tasks were discovered when using SEQ_31276.
For
FilterEventsHighFrequency
DeprecatedAlgorithm
rather than just having a comment in the algorithm descriptionFor
GenerateEventsFilter
:TimeType
variable is unclear in its usage/meaningSampleTemp
from 276 to 288 in steps of 1, the tables generated start at 275.5 degrees rather than 276.SplittersInformationWorkspace
toInformationWorkspace
OutputWorkspace
and theSplittersInformationWorkspace
should agree on the common column heading ofWorkspaceGroup
and the values should match rather than be one off (information starts from zero, output starts from one)OutputWorkspace
that have zero time between the start and stop (rows 3 through 7 in my test). They should not appear.For
FilterEvents
OutputWorkspaceBaseName_unfiltered
GenerateEventsFilter
, change the name ofSplittersInformationWorkspace
InputSplittersWorkspace
toSplitterWorkspace
The text was updated successfully, but these errors were encountered: