Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in VSI Peak Display #7198

Closed
OwenArnold opened this issue Jan 10, 2013 · 2 comments
Closed

Bug in VSI Peak Display #7198

OwenArnold opened this issue Jan 10, 2013 · 2 comments
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Vates
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC6363, TRAC6364

Reported by Dennis:

I checked on the problem with displaying the scatter plot and set of
peaks on the same VSI display. The problem seems to be due to the
choice of sample instead of lab coordinate systems. Specifically, if
ConvertToDiffractionMDWorkspace is used and lab coordinates are
specified, then found peaks are overlaid on the data correctly. If
sample coordinates are specified, the found peaks don't match the data.
Since ConvertToMD ONLY does not provide for using lab coordinates, the
problem we ran into at the demo yesterday makes sense. This will be
an unavoidable problem when ConvertToDiffractionMDWorkspace "goes away".

My initial thoughts are that this could be done in a staged approach...

  1. Move the Transformation tools currently in the SliceViewer into a common location (Maybe Geometry).

  2. Modify the way that the vtkPeaksMarkerFactory works see vtkPeaksSource.cpp line 69 so that it utilises the transform code.

  3. To make things nicer, we should have an enum generated by each ConvertToMDAlgorithm type algorithm, which indicates what special coordinate system (if any the) outputs workspace is in, and store that on the IMDWorkspace. This was the approach originally discussed between Michael and myself. This might be best done under a separate ticket.

@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 6352

@OwenArnold
Copy link
Contributor Author

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Vates labels Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 2.4 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Vates
Projects
None yet
Development

No branches or pull requests

2 participants