Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICAT] Algorithm error reporting #7358

Closed
2 tasks done
OwenArnold opened this issue Jan 31, 2013 · 1 comment
Closed
2 tasks done

[ICAT] Algorithm error reporting #7358

OwenArnold opened this issue Jan 31, 2013 · 1 comment
Labels
Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocked by :

A lot of algorithms in the ICAT category are throwing the same basic exception message.

throw std::runtime_error("Error when getting the catalog information from the Facilities.xml file.");

Some of these were replaced as part of http://trac.mantidproject.org/mantid/ticket/6490 to give better information on login. It would be best if someone where to go through these error scenarios and check that

  • They are reporting the right information, which should be useful to the end-user
  • That there is reduced duplication of error messages. Looks like a lot of copy-paste at the moment.

The quick fix http://trac.mantidproject.org/mantid/ticket/6490 should also be reviewed, because the throwCatalogError() function is duplicated across two algorithms.

Nick. Reassign as you see appropriate. It might be that I'm the best person to look at this.


Keywords: ICAT

@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 6512

@OwenArnold OwenArnold added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant